Public pool no longer works since Bitcoin core 28.0

nmfretz · October 31, 2024, 2:15am

Thanks for reporting this @Badreality and @denny.

Looks like the Public Pool project is using this rpc-bitcoin library that passes jsonrpc as a number instead of a string:

github.com

vansergen/rpc-bitcoin/blob/ace0f6889d2454c741600bd2a85de410ca494f1d/src/rpc.ts#L413


      
            this.fullResponse = fullResponse ? true : false;
            this.wallet = typeof wallet === "string" ? wallet : undefined;
          }
          
          batch(body: JSONRPC | JSONRPC[], uri = "/") {
            return super.post({ body, uri });
          }
          
          async rpc(method: string, params = {}, wallet?: string) {
            const uri = typeof wallet === "undefined" ? "/" : "wallet/" + wallet;
            const body = { method, params, jsonrpc: 1.0, id: "rpc-bitcoin" };
            try {
              const response = await this.batch(body, uri);
              return this.fullResponse ? response : response.result;
            } catch (error) {
              if (error.error && error.error.error && error.error.result === null) {
                throw this.fullResponse ? error.error : error.error.error;
              }
              throw error;
            }
          }

Which is failing now that Bitcoin Core v28 is strictly adhering to JSON_RPC specs.

Edit: looks like Public Pool just merged the fix

Could I please get anyone that comes across this post to add a reaction to this github comment here so that Public Pool devs see the need to quickly update their code:

github.com/benjamin-wilson/public-pool

Comment by nmfretz - patch rpc-bitcoin to be compatible with bitcoin core 28.0

benjamin-wilson:master ← remcoros:patch-rpc-bitcoin

Thanks for this workaround @remcoros. I just went down a rabbithole after updati…ng Core to v28 and tracked the issue down to the `rpc-bitcoin` library which seems to be a dead project at this point. @benjamin-wilson do you have a timeline for testing+merging this and pushing an updated docker image? Public Pool is in the Umbrel app store and it would be great to update it with official docker images that maintain compatibility with Bitcoin Core v28. But if this is still a ways away I can just build an image to temporarily get Umbrel users back up and running until a new official image is released.

If an official update from Public Pool does not look imminent, then I can fork the project, merge the fix, and build a docker image to get Umbrel user’s back up and running temporarily until an official docker image is released.

Topic		Replies	Views
Curl -4 instead of curl -6 to bitcoin RPC?	0	100	February 25, 2024
Bitcoin-core client to access bitcoin rpc error 403 Support and Troubleshooting	0	1055	August 8, 2022
Public pool solo mine troubleshooting General Discussions	3	26	December 16, 2024
RPC to my Umbrel BTC node Support and Troubleshooting	6	2437	July 7, 2023
Use CKpool + Umbrel Bitcoin full node	0	299	March 13, 2024

Public pool no longer works since Bitcoin core 28.0

Related topics